Conversation
This was referenced Jan 31, 2024
Collaborator
|
let's change pr title to |
Collaborator
|
@jeffersoncasimir who would best the best person to review this PR? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has multiple Loris counterparts:
Events to Annotations: #9032
HED support: #9033
It aims to make the Python pipeline more compliant with the current BIDS standard.
It does so by replacing references of
annotationsfiles and terms with references toeventsfiles and terms.It also brings in support for ingesting dataset-level (from dataset-level
events.json) and instance-level (HEDcolumn inevents.tsv) HED Tags.Current HED limitations:
events.jsonIt also does some file name refactoring in the
database_libfolder to standardize the name structure.Some logic was also moved to new
database_libfiles.MAKE SURE YOU PATCH SQL + ADD BOTH SCHEMAS WITH THE
insert_hed_schema.phpTOOL IN ACES/LORIS PRS FIRST