[Schedule Module] add new schedule module into Loris #6150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
previously requested changes
Mar 10, 2020
Contributor
johnsaigle
left a comment
There was a problem hiding this comment.
Small review. Some of the code needs changing to meet the core LORIS standards.
I'm not really sure what's going on with the new classes being added that deal with SQL statements. It seems unusual for LORIS
Contributor
Author
|
@johnsaigle Thanks for your reviews. |
Contributor
Author
|
restart travis |
Contributor
Author
|
This PR can't start Travis. I will reopen it. |
Contributor
Author
|
restart travis |
a948c9e to
a2c99fb
Compare
Contributor
Author
|
@zaliqarosli Could you test this module? |
zaliqarosli
reviewed
Jul 20, 2020
Contributor
zaliqarosli
left a comment
There was a problem hiding this comment.
this all looks really good! there's just a space missing in the sql patch, and some php lines may still fail travis
i will approve review once they're resolved!
zaliqarosli
requested changes
Jul 20, 2020
Contributor
zaliqarosli
left a comment
There was a problem hiding this comment.
re-review after testing the front end
modules/schedule_module/php/schedulemoduleprovisioner.class.inc
Outdated
Show resolved
Hide resolved
zaliqarosli
requested changes
Jul 20, 2020
zaliqarosli
reviewed
Jul 20, 2020
zaliqarosli
reviewed
Jul 20, 2020
3a7732d to
604335e
Compare
Contributor
|
@kongtiaowang I have tested the PR and everything looks good except for one thing:
|
Contributor
|
All looks good but on the |
Contributor
Author
|
@GeorgeMurad visit is good now. |
driusan
added a commit
to driusan/Loris
that referenced
this pull request
Apr 15, 2024
This is a test to see if merging aces#6150 caused tests to fail. All tests were passing on the PR, but it was an old enough PR that it's possible that the static check rules were changed in the interm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Rewrite this module from IBIS.
Testing instructions
Test plan
