Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API] Adding dicom upload #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xlecours wants to merge 180 commits into from
Closed

[API] Adding dicom upload #6161

xlecours wants to merge 180 commits into from

Conversation

@xlecours
Copy link
Contributor

@xlecours xlecours commented Mar 16, 2020 •
edited
Loading

Copy of #5016

This adds
POST /candidates/<candid>/<visit>/dicoms to upload a dicom.
GET /candidates/<candid>/<visit>/dicoms/<filename>/processes to get the server processes related to that dicom upload (mri_upload)
POST /candidates/<candid>/<visit>/dicoms/<filename>/processes to start a mri_upload server process on that dicom.
GET /candidates/<candid>/<visit>/dicoms/<filename>/processes/<processid> to get the state of a process

This work is based on #4244
To see this PR changes go to xlecours/Loris@api-module-candidates-and-subs...xlecours:adding_dicom_upload

TODO:

kongtiaowang and others added 30 commits October 30, 2017 12:00
@kongtiaowang
Merge pull request aces#55 from aces/minor
b84083f 
[instrument_manager] Modularize instrument manager (aces#3185)
@kongtiaowang
Merge pull request aces#62 from aces/minor
2456e11 
mi
@kongtiaowang
Merge pull request aces#71 from aces/minor
073956a 
minor 2017-11-20
@xlecours
squash
e480ecb
@xlecours
merging minor
13c8dc0
@xlecours
adding candidatetable alias in where clause
13fcbcb
@xlecours
delegating MethodNotAllowed checks to endpoints subclasses
901d025 
adding OPTIONS requests handling
@xlecours
adding PUT /canddiate/$candid/$visit_label support for existsing visits
4123e2c
@xlecours
/candidates/$candid/$visit_label/instruments
c21c174
@xlecours
/candidate/$candid/$visit_lable/qc/imaging
05c2b5d
@xlecours
cleanup
6ebf4da 
put back useProject config check in candidate select
@xlecours
working on Dicoms
14ea08e
@xlecours
fixes
154e27b
@xlecours
GET /candidates/$candid/$visit_label/dicoms
0673d04
@xlecours
/canddiates/$candid/$visit_label/dicoms/$dicom
3626830
@xlecours
simplifying dataframework usage by adding DicomTar classes
356ba02
@xlecours
moving getDicoms to timepoint class
34b37d9
@xlecours
missing class variable
0db091c
@xlecours
fix phan
7fd82da
@xlecours
fix error_log
e46d6b8
@xlecours
fix visit subendpoint without a visit
faca53b
@xlecours
visit instrument
e8a1b15
@xlecours
/candidates/$candid/$visit_label/images
cbe460d
@xlecours
/candidates/$candid/$visit_label/images/$image
eff7a0d
@xlecours
working on visit images
e5a8638
@xlecours
Merge branch 'minor' into api-module-candidates-and-subs
d7b22e5
@xlecours
working on Image
f8f14f1
@xlecours
Merge branch 'api-module-candidates-and-subs' of github.com:xlecours/…
fed22c8 
…Loris into api-module-candidates-and-subs
@PapillonMcGill @xlecours
Update modules/api/php/candidatesprovisioner.class.inc
a15c3d6 
Co-Authored-By: xlecours <[email protected]>
@PapillonMcGill @xlecours
Update modules/api/php/candidatesprovisioner.class.inc
e14941b 
Co-Authored-By: xlecours <[email protected]>
@ridz1208 ridz1208 removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Sep 1, 2020
@xlecours xlecours mentioned this pull request Sep 18, 2020
Merged
@cmadjar
Copy link
Collaborator

cmadjar commented Jun 8, 2021

@xlecours could you rebase your branch?

@ridz1208
Copy link
Collaborator

ridz1208 commented Jun 23, 2021

@xlecours I rebased this for you here https://github.com/ridz1208/Loris/tree/adding_dicom_upload

if you want I can force push to your branch or you can simply pull it and force push it yourself.

@ridz1208
Copy link
Collaborator

ridz1208 commented Jun 28, 2021

@cmadjar @driusan this one is now rebased and seems to be passing tests

@cmadjar cmadjar assigned driusan and cmadjar and unassigned xlecours Jul 13, 2021
@xlecours xlecours self-assigned this Jul 13, 2021
@xlecours
Copy link
Contributor Author

xlecours commented Jul 13, 2021

This is missing integration tests. @xlecours

@driusan
Copy link
Collaborator

driusan commented Aug 10, 2021

@cmadjar can you review?

@xlecours
Copy link
Contributor Author

xlecours commented Nov 29, 2022

@xlecours If you do the rebase, @cmadjar agreed to review it again. Also, now that we have a testsuite for the api module, you should add some tests.

@driusan
Copy link
Collaborator

driusan commented Nov 30, 2022

@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?

@xlecours
Copy link
Contributor Author

xlecours commented Nov 30, 2022

@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests?

Yes, I am.

@maximemulder maximemulder mentioned this pull request Mar 20, 2024
Merged
@ridz1208 ridz1208 added the Priority: High PR or issue should be prioritised over others for review and testing label Jul 2, 2024
@driusan
Copy link
Collaborator

driusan commented Nov 7, 2024

Replaced by #9154

@driusan driusan closed this Nov 7, 2024
driusan pushed a commit that referenced this pull request May 23, 2025
@maximemulder
[API] Add dicom upload (#9154)
0883fde 
This is a port of [#6161](#6161),
which contains a description of the changes. It adds endpoints to
the LORIS API for uploading dicom archives
CamilleBeau pushed a commit to CamilleBeau/Loris that referenced this pull request Jun 10, 2025
@maximemulder @CamilleBeau
[API] Add dicom upload (aces#9154)
dad7b72 
This is a port of [aces#6161](aces#6161),
which contains a description of the changes. It adds endpoints to
the LORIS API for uploading dicom archives
SKADE2303 pushed a commit to SKADE2303/Loris that referenced this pull request Jun 26, 2025
@maximemulder
[API] Add dicom upload (aces#9154)
575f643 
This is a port of [aces#6161](aces#6161),
which contains a description of the changes. It adds endpoints to
the LORIS API for uploading dicom archives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltheism maltheism maltheism left review comments

Assignees

@cmadjar cmadjar

@maximemulder maximemulder

Labels

Area: API PR or issue related to the API Category: Feature PR or issue that aims to introduce a new feature Priority: High PR or issue should be prioritised over others for review and testing State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@xlecours @driusan @cmadjar @ridz1208 @maltheism @johnsaigle @maximemulder @kongtiaowang @PapillonMcGill