Fix SQL error for duplicate rows in [tools] detect_duplicated_commentids.php #8305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@GeorgeMurad The array you are getting now will be an array of arrays as opposed to the pselect row call that simply returns a 1D array. you need to handle the code below properly |
Collaborator
|
@driusan this should probably go to 24.1, please confirm |
Collaborator
|
Yes, I think it should go to 24.1 |
Collaborator
|
@GeorgeMurad can you please rebase this as requested |
Collaborator
|
merged in 24.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the select query from pselectRow tp pselect on line 105 under [tools] detect_duplicated_commentids.php file
Issue: #8060