Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[acknowledgements] Remove "Present" column from database and dynamically calculate #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 3 commits into from
Jul 11, 2024
Merged

[acknowledgements] Remove "Present" column from database and dynamically calculate #8339

driusan merged 3 commits into from
Jul 11, 2024

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Jan 24, 2023 •
edited by ridz1208
Loading

Since this was triggered by confusion over what "Present" means, this also updates the help text to add a brief description.

Resolves #6231

@driusan
[acknowledgements] Remove "Present" column from database and dynamica…
a4701b8 
…lly calculate

Since this was triggered by confusion over what "Present" means, this also
updates the help text to add a brief description.

Resolves aces#6231
@driusan
Add back column/filter on frontend
d012531
@driusan
Include cleanup patch
5b0261a
@ridz1208 ridz1208 changed the title [acknowledgements] Remove "Present" column from database and dynamica… [acknowledgements] Remove "Present" column from database and dynamically calculate Jul 2, 2024
@ridz1208 ridz1208 assigned cmadjar and unassigned driusan Jul 2, 2024
@ridz1208 ridz1208 added the Priority: High PR or issue should be prioritised over others for review and testing label Jul 2, 2024
cmadjar
cmadjar approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@driusan driusan merged commit 55c328d into aces:main Jul 11, 2024
@kongtiaowang kongtiaowang mentioned this pull request Jul 15, 2024
Merged
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Sep 25, 2024
@driusan @maximemulder
[acknowledgements] Remove "Present" column from database and dynamica…
5a70957 
…lly calculate (aces#8339)

Since this was triggered by confusion over what "Present" means, this
also updates the help text to add a brief description.

Resolves aces#6231
ZhichGaming pushed a commit to ZhichGaming/Loris that referenced this pull request Nov 25, 2024
@driusan @ZhichGaming
[acknowledgements] Remove "Present" column from database and dynamica…
dc42f86 
…lly calculate (aces#8339)

Since this was triggered by confusion over what "Present" means, this
also updates the help text to add a brief description.

Resolves aces#6231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees

@cmadjar cmadjar

Labels

Priority: High PR or issue should be prioritised over others for review and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[acknowledgements] "Present" option in module unclear

3 participants

@driusan @cmadjar @ridz1208