[configuration] Reactify module #8471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d885e9f to
b47f3a2
Compare
Collaborator
Author
|
@kongtiaowang rebased |
| { | ||
|
|
||
| $this->safeGet($this->url . "/configuration/"); | ||
| // wait for the React to render |
Contributor
There was a problem hiding this comment.
Please replace this function in this file. using safeFindElement replace findElements after Reactify.
private function _linkTest($text)
{
$this->safeClick(WebDriverBy::linkText($text));
$webActives = $this->safeFindElement(WebDriverBy::cssSelector(".active"));
$bodyText = $webActives->getText();
$this->assertStringContainsString($text, $bodyText);
}
Contributor
There was a problem hiding this comment.
Regarding the testplan3 in the dashboard test, you can temporarily comment it out. I've identified a solution to address this issue, and I'll implement it later. https://github.com/kongtiaowang/Loris/pull/381/files#diff-2af5e853d357c98c23e22e3a7d855bc560485103cb82026fa408d7fdf6f3fa5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewritse the main page of the configuration module--which is the cause of the majority of our javascript warnings--with React. The configuration module was written with jQuery/smarty before we began using React.
The reactified version should work the same as the old with a few exceptions.
Other than that, the module should be unchanged from the end-user perspective.