Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Apr 19, 2023

  • Add the brainbrowser js files to the list of files parsed by eslint
  • Remove the bracket notation for the minc_id param: brainbrowser/?minc_id=[32,33] -> brainbrowser/?minc_id=32,33
  • Display an error when the loader fails instead of LOADING...

Fixes #8016, #7681

@laemtl laemtl added this to the 25.0.0 milestone Apr 19, 2023
@laemtl laemtl changed the base branch from main to 25.0-release April 19, 2023 03:47
@laemtl laemtl added the Critical to release PR or issue is key for the release to which it has been assigned label Apr 19, 2023
@driusan
Copy link
Collaborator

driusan commented Apr 19, 2023

Why is the brackets removed? That seems like an arbitrary breaking change if there's not a reason for it.

@cmadjar cmadjar self-assigned this Apr 19, 2023
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Very nice to have the error message instead of the never ending loading message. 👍

@cmadjar cmadjar added the Passed manual tests PR has been successfully tested by at least one peer label Apr 19, 2023
@laemtl
Copy link
Contributor Author

laemtl commented Apr 19, 2023

Why is the brackets removed? That seems like an arbitrary breaking change if there's not a reason for it.

The url params bracket notation is not valid and requires extra parsing. Since those extra brackets aren't necessary, I switched to the native comma separated notation that can do the same job. I carefully covered all the cases so I don't believe it will introduces any breaking changes. I can also revert the changes if you find it safer.

@driusan
Copy link
Collaborator

driusan commented Apr 19, 2023

I don't think we should risk breaking existing links and the code to strip the [ and ] is already there. It's safer and keeping them makes the empty case cleaner.

@laemtl
Copy link
Contributor Author

laemtl commented Apr 19, 2023

I don't think we should risk breaking existing links and the code to strip the [ and ] is already there. It's safer and keeping them makes the empty case cleaner.

Ok, I will revert the change then :)

@laemtl laemtl added the State: Needs work PR awaiting additional work by the author to proceed label Apr 19, 2023
@laemtl laemtl force-pushed the brainbrowser-404-fix branch from 4e7651e to 5b7ec9c Compare April 19, 2023 20:21
@laemtl laemtl removed the State: Needs work PR awaiting additional work by the author to proceed label Apr 19, 2023
@laemtl
Copy link
Contributor Author

laemtl commented Apr 19, 2023

@driusan Reverted

@driusan driusan merged commit edd6eef into aces:25.0-release Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical to release PR or issue is key for the release to which it has been assigned Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Brainbrowser] Constantly loading when accessing image

3 participants