-
Notifications
You must be signed in to change notification settings - Fork 189
Brainbrowser 404 fix #8643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brainbrowser 404 fix #8643
Conversation
|
Why is the brackets removed? That seems like an arbitrary breaking change if there's not a reason for it. |
cmadjar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. Very nice to have the error message instead of the never ending loading message. 👍
The url params bracket notation is not valid and requires extra parsing. Since those extra brackets aren't necessary, I switched to the native comma separated notation that can do the same job. I carefully covered all the cases so I don't believe it will introduces any breaking changes. I can also revert the changes if you find it safer. |
|
I don't think we should risk breaking existing links and the code to strip the |
Ok, I will revert the change then :) |
4e7651e to
5b7ec9c
Compare
|
@driusan Reverted |
Fixes #8016, #7681