Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[issue_tracker] Do not display inactive users in issue form #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 5 commits into from
Nov 7, 2023
Merged

[issue_tracker] Do not display inactive users in issue form #8841

driusan merged 5 commits into from
Nov 7, 2023

Conversation

@charlottesce
Copy link
Contributor

@charlottesce charlottesce commented Jul 19, 2023

Brief summary of changes

Inactive users are not displayed in dropdowns to assign / watch an issue

Testing instructions (if applicable)

  1. Go to Tools -> Issue Tracker
  2. Make a new issue / edit an existing one -> ensure you don't see any inactive user in the "Assignee" nor "Add others to watching" dropdowns

Note

This is a CCNA override - https://github.com/aces/CCNA/pull/4100

@CamilleBeau CamilleBeau self-assigned this Aug 10, 2023
@laemtl laemtl requested review from laemtl and removed request for laemtl August 10, 2023 14:07
CamilleBeau
CamilleBeau requested changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well! I am however wondering now if we should also not display users that have Pending_approval='Y'?

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Aug 10, 2023
CamilleBeau
CamilleBeau requested changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Dave's request, can we add the assignee / watchers that are currently assigned to the issue to the drop down even if they are inactive? Should be simple to do with a join on issues using issueID from $values, and an OR statement

@CamilleBeau CamilleBeau added State: Needs work PR awaiting additional work by the author to proceed and removed Passed manual tests PR has been successfully tested by at least one peer labels Aug 10, 2023
@charlottesce
Copy link
Contributor Author

charlottesce commented Aug 14, 2023

Two other changes have been added as bug fixes I noticed during testing:

  1. Added a getBreadcrumbs function for the edit class, otherwise we get the following error when clicking on the 'Issue' link of the path on the top left of the page, as it links to 'issue_tracker/issue' which doesn't exist.
    image

  2. The updateComments function of the edit class can now take a null value as input, otherwise if someone tries to update an issue without adding a comment, a PHP error is raised that updateComments expects a string while null is given.

@charlottesce charlottesce removed the State: Needs work PR awaiting additional work by the author to proceed label Aug 14, 2023
@CamilleBeau
Copy link
Collaborator

CamilleBeau commented Oct 24, 2023

Working well!

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Oct 24, 2023
@driusan driusan merged commit d746654 into aces:24.1-release Nov 7, 2023
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

Assignees

@CamilleBeau CamilleBeau

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

24.1.6

Development

Successfully merging this pull request may close these issues.

4 participants

@charlottesce @CamilleBeau @driusan @ridz1208