[IssueTracker] Add description field to issues table #8864
Conversation
|
@racostas is this ready for your review? |
Yes, I did a first pass with him "in person" before the end of the GSoC period. The comments were properly addressed but it's missing a second test/review. I had been a bit taken with CCNA upgrade since them. If after second review there is something to fix I will take care myself. |
|
Thanks @racostas @SantiagoTG or @driusan or @ridz1208 could you please suggest/nominate an additional reviewer on this PR? Then it should be ready to merge to help our GSOC student wrap up his summer. thanks! |
CamilleBeau
left a comment
There was a problem hiding this comment.
Missing the patch in "New_patches" directory to add the changes
Getting this error:
SQL/New_patches/2024-02-06-issuetracker_AddsDescriptionToIssuesTable.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: CamilleBeau <[email protected]>
CamilleBeau
left a comment
There was a problem hiding this comment.
Everything works well now. The only thing (but I don't think it's related to this PR) is that the "New issue" page does not load because there is a missing jsx/Form import for FileElement. This can be solved by adding this line in IssueForm.js
I added it to test. Even though it's not caused by this PR I think it would be good to fix here
Yes, definitely something we can address in as part of this PR too. Thanks Camille. |
|
ready to be re-reviewed. |
|
@racostas I have tested the changes, and they work as expected without any issues. Looks good to me! |
|
@CamilleBeau GitHub still says you requested changes, can you re-review? |
ay-bh
left a comment
There was a problem hiding this comment.
tools/update_issues_with_description.php gives this error.
[DEBUG] SELECT issueID FROM issues_comments
[DEBUG] SELECT `description` FROM issues WHERE issueID=:14 LIMIT 2
[DEBUG] SELECT issueComment
FROM issues_comments ic
WHERE ic.issueID = :14
ORDER BY ic.dateAdded ASC
LIMIT 1 LIMIT 2
PHP Fatal error: Uncaught PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 2' at line 5 in /var/www/loris/php/libraries/Database.class.inc:695
Stack trace:
#0 /var/www/loris/php/libraries/Database.class.inc(695): PDOStatement->execute()
#1 /var/www/loris/php/libraries/Database.class.inc(745): Database->execute()
#2 /var/www/loris/php/libraries/Database.class.inc(841): Database->pselect()
#3 /var/www/loris/php/libraries/Database.class.inc(981): Database->pselectRow()
#4 /var/www/loris/tools/update_issues_with_description.php(52): Database->pselectOne()
#5 {main}
thrown in /var/www/loris/php/libraries/Database.class.inc on line 695
@driusan Done! |
Fixed : PHP Fatal error: Uncaught PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 2' at line 5 in /var/www/loris/php/libraries/Database.class.inc:695
Add an explicit "description" table to the issues table. The description is currently counter-intuitively taken from the first comment which is counter-intuitive and makes it impossible to edit a description after an issue is created. This adds an explicit column. Resolves aces#8353
Add an explicit "description" table to the issues table. The description is currently counter-intuitively taken from the first comment which is counter-intuitive and makes it impossible to edit a description after an issue is created. This adds an explicit column. Resolves aces#8353
Brief summary of changes
Link(s) to related issue(s)