[TypeScript] Convert InfoPanel.js to TypeScript #8944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts the InfoPanel component from JavaScript to TypeScript in order to make it easier to import/type check in TS (without affecting the ability to load it in JS.) (The component is small enough that this is easier than writing a .d.ts file and keeping it in sync.)
1819cb9 to
093be21
Compare
laemtl
approved these changes
Nov 13, 2023
laemtl
reviewed
Nov 13, 2023
| * @returns {ReactNode} - the InfoPanel | ||
| */ | ||
| function InfoPanel(props) { | ||
| function InfoPanel(props: {children: ReactNode}): ReactNode { |
Contributor
There was a problem hiding this comment.
const InfoPanel : React.FC<{children: ReactNode}> = (props) => {
Contributor
There was a problem hiding this comment.
Use generics to inherit React.FC type definition
Collaborator
Author
There was a problem hiding this comment.
I don't understand.. what parent type definitions? It is a functional component (which presumably is what the FC stands for in your example, but there is no parent..)
Contributor
There was a problem hiding this comment.
Making use of the React.FC generic type will specifies the return type. But it seems it will be deprecated soon, so let's leave it as is: facebook/create-react-app#8177
laemtl
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the InfoPanel component from JavaScript to TypeScript in order to make it easier to import/type check in TS (without affecting the ability to load it in JS.)
(The component is small enough that this is easier than writing a .d.ts file and keeping it in sync.)