[TypeScript] Add TypeScript module definition for fetchDataStream #8945
Conversation
This adds a .d.ts file to accompany the functions defined in jslib/fetchDataStream.d.ts, allowing them to be type checked in typescript with noImplicitAny enabled.
| rowcb: (row: string[]) => void, | ||
| chunkcb: () => void, | ||
| endstreamcb: () => void, | ||
| method: string |
There was a problem hiding this comment.
Might be good to switch for an enum: 'GET' | 'PUT' | 'POST' | 'PATCH' | 'DELETE'
There was a problem hiding this comment.
Hum, I don't see this param in the function def: https://github.com/aces/Loris/blob/main/jslib/fetchDataStream.js#L45
There was a problem hiding this comment.
Hm.. you're right. I wrote the .d.ts file for this: https://github.com/aces/Loris/pull/8907/files#diff-7409e296bbfa103b243c29d76808eae3ed3a59d2b4ec00498e7607b05858a457L56-L60
Do you want me to add the change to the function to this PR too?
There was a problem hiding this comment.
I see. That's not necessary, I assume you will do the merges in the appropriate order :)
There was a problem hiding this comment.
I would prefer to do it here to keep them in sync, I'll port it over
This adds a .d.ts file to accompany the functions defined in jslib/fetchDataStream.d.ts, allowing them to be type checked in typescript with noImplicitAny enabled.