Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[candidate_parameters] use DoB and DoD format #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 2 commits into from
Jan 23, 2024
Merged

[candidate_parameters] use DoB and DoD format #9001

driusan merged 2 commits into from
Jan 23, 2024

Conversation

@CamilleBeau
Copy link
Collaborator

@CamilleBeau CamilleBeau commented Dec 8, 2023 •
edited
Loading

Brief summary of changes

This PR uses the DoB and DoD format from configuration in the DoB and DoD tabs respectively.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Modify the DoB and DoD format in the configuration module
  2. Make sure that these formats are respected in their respective tabs in the candidate parameters module
  3. Try saving the DoB and DoD in each new format, make sure it saves properly and loads properly
  4. Make sure to test on candidates with and without DoB and DoD

Link(s) to related issue(s)

miladheshmati
miladheshmati approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@miladheshmati miladheshmati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@miladheshmati
Copy link
Contributor

miladheshmati commented Jan 15, 2024

When I am trying to submit a change in the configuration module, this 404 error appears:

Screenshot 2024-01-15 at 9 01 27 AM

@miladheshmati miladheshmati added the State: Needs work PR awaiting additional work by the author to proceed label Jan 15, 2024
@CamilleBeau
Copy link
Collaborator Author

CamilleBeau commented Jan 16, 2024

@miladheshmati I don't think this is related to this PR? I'm only modifying candidate parameters here

@miladheshmati miladheshmati added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Jan 22, 2024
@driusan driusan merged commit 94c0adb into aces:main Jan 23, 2024
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miladheshmati miladheshmati miladheshmati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miladheshmati miladheshmati

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

26.0.0

Development

Successfully merging this pull request may close these issues.

[Candidate parameter] DoB and DoD formats ignored

4 participants

@CamilleBeau @miladheshmati @driusan @ridz1208