[electrophysiology_browser] Revised EEG filters + Store reference fix#9038
[electrophysiology_browser] Revised EEG filters + Store reference fix#9038
Conversation
This reverts commit 2a6b8d4.
|
@laemtl can you review? |
|
@jeffersoncasimir I can't merge this because of a conflict, can you rebase? |
There was a problem hiding this comment.
Why is this being ignored? If ts flags something it's usually for a reason.
There was a problem hiding this comment.
I am not sure why. It was not introduced by this PR (or myself) and there seems to be many instances of // @ts-ignore throughout the module
There was a problem hiding this comment.
Huh? This line is being introduced by you in this PR.
There was a problem hiding this comment.
You're right. However it is also present 11 lines above, as well as in the other <ResponsiveViewer> component in SeriesRenderer.tsx.
It seems to be related to export default withParentSize(ResponsiveViewer) at the end of ResponsiveViewer.tsx.
Here is the error I get when I remove the // @ts-ignore line you pointed out (different branch, but refers to same place):
There was a problem hiding this comment.
That sounds like a real error that needs to be investigated.
There was a problem hiding this comment.
I believe I found an appropriate solution. It has been pushed to this PR.
…aces#9038) This does the following: - Uses a revised set of coefficients values for the filters, depending on the recording's sampling frequency - Uses multiple store references when there are multiple recordings. It would previously get overwritten. The following script was used to generate the coefficients: ``` samp = 512; % Change to target frequency order = 3; low_pass_items = [15 20 30 40 60]; high_pass_items = [0.5 1 5 10]; for i=1:length(low_pass_items) disp(strcat(num2str(low_pass_items(i)), ' low pass')); [b, a] = butter(order-1, (low_pass_items(i) / samp), 'low') % argument is (order - 1) end for i=1:length(high_pass_items) disp(strcat(num2str(high_pass_items(i)), ' high pass')); [b, a] = butter(order-1, (high_pass_items(i) / samp), 'high') % argument is (order - 1) end ```
This PR does the following:
The following script was used to generate the coefficients: