[help] fix the help widget extending over the height of a page#9105
[help] fix the help widget extending over the height of a page#9105
Conversation
|
@shonibare can you provide screenshots of the before and after ? |
|
Before After |
|
@shonibare I still see it extending in width past the size of the page as described in the issue |
Fixed @ridz1208 |
|
I can't seem to recreate the original issue with the horizontal space. Due to the horizontal fix, my help box seems to be 30px away from the right side of the screen now - is there a way to only add the 30px IF it is extending the page? The vertical fix is working well though |
|
@skarya22 change your first name last name to very short values (i.e. Rida test instead of Admin account) and you will get the horizontal issue |
htdocs/main.css
Outdated
| @@ -684,11 +684,12 @@ tr.directentry { | |||
| border-top: none; | |||
| border-width: 1px; | |||
| position: absolute; | |||
There was a problem hiding this comment.
| position: absolute; | |
| position: fixed; | |
| right: 0; |
I think this would be a better solution as it works irrelevant of how long the name is.
There was a problem hiding this comment.
Yes, it still works on my screen, updated the changes. I hope the help widget is positioned same place on your screen compared to your previous screenshot? @skarya22
There was a problem hiding this comment.
With the changes I could see it aligned with the right side of the screen no matter the name length! Thank you for updating with the changes requested
issue #9087
This PR fixes the help widget height extending over a page