fix db installer host name #9107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nicolasbrossard can you review and test? |
Collaborator
|
@maximemulder changes look good, pending check on other locations to approve |
Contributor
Author
Done (I probably should have done that before tbh, my fault). I also looked for other uses of Also, as explained in the following comment, this change must be tested on MariaDB >= 10.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fix the database installer so that the 'Host' field name matches the name found in the database. This difference prevented Loris from being installed on systems in which the database returns tables whose field names are capitalized according to their name in the database, and not in the query (our dev VMs does the latter, hence why we did not have this bug during development).
Testing instructions
Run the database installer on a system with a database whose returned field names are not capitalized according to the query.
Links to related issues