StaticDataTable mixed column types sorting #9120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
requested changes
Mar 11, 2024
Contributor
maximemulder
left a comment
There was a problem hiding this comment.
Thanks for the code, here is my review. I also strongly suggest moving this code to its own function/method to isolate the logic from the rest of the code.
Contributor
maximemulder
left a comment
There was a problem hiding this comment.
Some more comments but I won't block on that.
Contributor
Author
|
@maximemulder Thanks for the review :) |
maximemulder
approved these changes
Mar 12, 2024
Collaborator
|
Sorry, missed that this was ready to go because i've mostly been looking at the release issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
When mixing numbers with strings in an instrument field value (e.g. text field) results in a DQT column that has a sorting issues. This happened for a "summary" instrument in HBCD project that import results from multiple other instruments. This instrument has to clearly display the value of the field (i.e. numeric) or "No data" (i.e. string).
Testing instructions (if applicable)
Link(s) to related issue(s)
Linked to HBCD#1652