[Login] password reset page- missing element import #9171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisoc
approved these changes
Apr 4, 2024
Contributor
regisoc
left a comment
There was a problem hiding this comment.
LGTM, tested on my VM.
- Error raised when mismatching passwords in the "change password page", no redirection to a blank page.
- Cannot re-use an already used one-time password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
StaticElement
#9143
[login] Update password page still accessible with expired one-time password #9144
Testing instructions (if applicable)
Testing reset password page and submitting two mismatching passwords, it will show the error, not the blank page.