[Behavioural_QC] Display profile level feedbacks#9192
Merged
Conversation
Collaborator
|
@CamilleBeau This has conflicts in the changelog |
Collaborator
Author
|
@driusan resolved! |
…entries' into 2024_04_04_bvl_feedback_profile_entries
nicolasbrossard
approved these changes
Apr 11, 2024
Contributor
nicolasbrossard
left a comment
There was a problem hiding this comment.
Code looks code and PR works as expected on my VM. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR changes the query for the behavioural feedback tab of the Behavioural QC module to use "LEFT JOIN" instead of "JOIN" on visit specific tables so that profile level feedbacks that do not relate to any visit will be displayed.
COALESCE function is used for the project and site fields to take the visit project / site if it exists, and the candidate project / site otherwise.
The link to the profile is also added in the feedback level column.
Testing instructions (if applicable)
Link(s) to related issue(s)