Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[SQL][Instrument List][Battery Manager] Move DDE Enabled to Test_Battery#9264

Merged
driusan merged 50 commits intoaces:mainfrom
skarya22:2024_05_13_Move_DDE_To_Battery
Oct 31, 2024
Merged

[SQL][Instrument List][Battery Manager] Move DDE Enabled to Test_Battery#9264
driusan merged 50 commits intoaces:mainfrom
skarya22:2024_05_13_Move_DDE_To_Battery

Conversation

@skarya22
Copy link
Contributor

@skarya22 skarya22 commented May 14, 2024 •
edited
Loading

Brief summary of changes

  • Changed the logic for DDE being enabled to be moved from Config to Test_Battery so that it can be managed on a visit-instrument basis instead of just instrument.
  • Modified Battery Manager to have a section for editing which battery has DDE enabled
  • Modifies Raisinbread to match the sql changes
image

Testing instructions (if applicable)

  1. Confirm that the sql patch copies over the selected DDE instruments to the test_battery field properly
  2. Test all affected tools and confirm they still work as intended
  3. Confirm that the correct tests show the DDE option in instrument list for the visit-instrument tuple as defined in test_battery

@skarya22 skarya22 marked this pull request as ready for review May 16, 2024 20:12
@skarya22 skarya22 changed the title [SQL][Instrument List] Move DDE Enabled to Test_Battery [SQL][Instrument List][Instrument Manager] Move DDE Enabled to Test_Battery May 17, 2024
@driusan driusan mentioned this pull request Sep 24, 2024
Open
@skarya22
Copy link
Contributor Author

skarya22 commented Sep 24, 2024

@driusan I think I made the necessary adjustments. I could not find anything in the swagger documentation to update however.
0.0.4-dev:
image

0.0.3:
image

@skarya22 skarya22 requested a review from driusan September 25, 2024 17:27
@skarya22 skarya22 assigned driusan and unassigned skarya22 Sep 25, 2024
@driusan
Copy link
Collaborator

driusan commented Oct 15, 2024

@skarya22 can you rebase this? There is a conflict

@driusan
Copy link
Collaborator

driusan commented Oct 29, 2024

@skarya22 There are still conflicts that prevent this from being merged

@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Oct 29, 2024
@skarya22 skarya22 self-assigned this Oct 29, 2024
@skarya22
Copy link
Contributor Author

skarya22 commented Oct 29, 2024

@driusan sorry everything has conflicts after the lint changes this morning

@skarya22 skarya22 removed their assignment Oct 31, 2024
@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2024
@driusan driusan merged commit bf53274 into aces:main Oct 31, 2024
ZhichGaming pushed a commit to ZhichGaming/Loris that referenced this pull request Nov 25, 2024
@skarya22 @ZhichGaming
[SQL][Instrument List][Battery Manager] Move DDE Enabled to Test_Batt…
0cec034 
…ery (aces#9264)

- Changed the logic for DDE being enabled to be moved from Config to Test_Battery so that it can be managed on a visit-instrument basis instead of just instrument.
- Modified Battery Manager to have a section for editing which battery has DDE enabled
@skarya22 skarya22 mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shonibare shonibare Awaiting requested review from shonibare

@driusan driusan Awaiting requested review from driusan

Assignees

@driusan driusan

Labels

None yet

Projects

LORIS RoadMap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skarya22 @ridz1208 @driusan @shonibare @CamilleBeau