Defining default decimal point for non JSON table LINST instruments #9277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@driusan I was thinking we could have a (14,4) default which would be backwards compatible with the old (10,0) default but also allow the LINST standard to define the number of digits and number of decimals in the front end? just likesome fields have min and max? |
Contributor
Author
Collaborator
|
@regisoc I'm not sure how the option would work but it sounds good to me. (I think the first part of the Should I merge this and you'll do it in another PR or do you want to do it in this one? |
Contributor
Author
maximemulder
pushed a commit
to maximemulder/Loris
that referenced
this pull request
Sep 25, 2024
…#9277) This forces the decimal(14,4) (10 digits on the integer part, and 4 digits on the floating point part), instead of decimal(10,0) which is the default for numeric and was truncating floating point digits. It only applies this change for instruments that require their own table (non JSON) and have numeric attribute. Resolves aces#9237
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
…#9277) This forces the decimal(14,4) (10 digits on the integer part, and 4 digits on the floating point part), instead of decimal(10,0) which is the default for numeric and was truncating floating point digits. It only applies this change for instruments that require their own table (non JSON) and have numeric attribute. Resolves aces#9237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR forces the
decimal(14,4)(10 digits on the integer part, and 4 digits on the floating point part), instead ofdecimal(10,0)which is the default fornumericand was truncating floating point digits.It only applies this change for instruments that require their own table (non JSON) and have
numericattribute.Testing instructions (if applicable)
tools/generate_tables_sql.phpandtools/generate_tables_sql_and_testNames.phpwith a non JSON LINST instrument with at least anumerictype line.decimal(14,4)type for the numeric attribute, instead of anumericattribute.Link(s) to related issue(s)
Resolves #9237