[dataquery/instruments] Handle cardinality::many instruments in DQT #9305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability for the frontend to display session variables with a cardinality of "many" per session was added for the imaging, but the instrument queryengine was not updated to properly format multi-select elements. This adds support for multiselect elements by updating the instrument queryengine to return correctly formatted data for instruments.
Collaborator
|
@GeorgeMurad could you please review and test this PR? Thank you! |
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Oct 10, 2024
…ces#9305) The ability for the frontend to display session variables with a cardinality of "many" per session was added for the imaging, but the instrument queryengine backend was not updated to properly format multi-select elements. This adds support for multiselect elements by updating the instrument queryengine to return correctly formatted data for instruments with the many cardinality.
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
Oct 10, 2024
…ces#9305) The ability for the frontend to display session variables with a cardinality of "many" per session was added for the imaging, but the instrument queryengine backend was not updated to properly format multi-select elements. This adds support for multiselect elements by updating the instrument queryengine to return correctly formatted data for instruments with the many cardinality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability for the frontend to display session variables with a cardinality of "many" per session was added for the imaging, but the instrument queryengine backend was not updated to properly format multi-select elements. This adds support for multiselect elements by updating the instrument queryengine to return correctly formatted data for instruments with the many cardinality.