[candidate_profile] Add error boundary to cards with errors #9333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an error boundary to the jsx/Card class, so that when a widget doesn't render properly on the candidate profile page that widget is displayed with an error and the rendering of other widgets is unaffected, instead of showing a blank page.
fd06aaa to
feff8ba
Compare
Collaborator
|
@GeorgeMurad could you review and test this PR? |
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
This adds an error boundary to the jsx/Card class, so that when a widget doesn't render properly on the candidate profile page that panel is displayed with an error and the rendering of other widgets is unaffected, instead of crashing and showing a blank page. Fixes an issue I can't find keywords to find the reference for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an error boundary to the jsx/Card class, so that when a widget doesn't render properly on the candidate profile page that panel is displayed with an error and the rendering of other widgets is unaffected, instead of crashing and showing a blank page.
Fixes an issue I can't find keywords to find the reference for.