[Optimization/dataquery] Remove unnecessary array #9348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2024 11:02
The InstrumentQueryEngine converts the results of a query that returns all values from an iterator to an array because it's used twice. However, the second usage is unnecessary as the data is available in another way. This switches the second usage to be array_keys of a variable created in the first iteration and removes the iterator_to_array, which should result in less memory usage as it can be freed after the first iteration.
Collaborator
Author
|
I did not touch that line because that whole section is rewritten by #9344 (which includes the strval) and would cause conflicts. |
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
The InstrumentQueryEngine converts the results of a query that returns all values from an iterator to an array because it's used twice. However, the second usage is unnecessary as the data is available in another way. This switches the second usage to be array_keys of a variable created in the first iteration and removes the iterator_to_array, which should result in less memory usage as it can be freed after the first iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InstrumentQueryEngine converts the results of a query
that returns all values from an iterator to an array because
it's used twice. However, the second usage is unnecessary as the
data is available in another way. This switches the second usage
to be array_keys of a variable created in the first iteration and
removes the iterator_to_array, which should result in less memory
usage as it can be freed after the first iteration.