-
Notifications
You must be signed in to change notification settings - Fork 189
[data_release] Introduce Project Separation #9385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data_release] Introduce Project Separation #9385
Conversation
|
@shonibare sorry about that! resolved, but make sure you compile because the manage permissions form should look like this, not the screenshot |
|
@skarya22, you are right. I retested it again, and it produced the expected result. A user can not manage permissions or see files not affiliated with its site. |
shonibare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add project separation permissions for the data release module - This makes it so that users do not see data_release files from different projects. - If a data_release file does not have a projectID, then all users with access to that version/file can see it. - Improved the manage permission form because it was not very user friendly - Version and user options only show up as the ones that the current user has access to that project for
Brief summary of changes
Testing instructions (if applicable)
Data Release: Grant Other Users Access to Releases permissionRelated to CCNR PR 7445