-
Notifications
You must be signed in to change notification settings - Fork 189
[imaging_qc] fix module to display only data affliated to user's site and project #9399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imaging_qc] fix module to display only data affliated to user's site and project #9399
Conversation
skarya22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix so that scans from projects the user does not have do not show.
skarya22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
If a user has sites A, B, and C and a candidate has sites C, and D, my understanding of this change is that it will make it so that the user sees the candidate but it only shows it as having site "C". Is that correct? If so, I think it should be discussed at a LORIS meeting. |
@driusan Yes, you are right. The page should only display data from the sites and projects to which the user has access, as well as the site and project filters as reported in the issue. |
…nd project
Fixes #6591
To Test
Make sure not to include
View all-sites Imaging Browser pagesor any other permissions2. Assign the user site e.g "Ottawa" and project "Pumpernickel"
3. Log in as this user, and navigate to the imaging quality control module
4. Observe that the front page loads with data pertaining only to the user site and project
5. Observe that the
sitefilter only allows filtering only to the user's site6. Observe that the
projectfilter allows filtering only to the user's project