[timepoint] Add Default Site to Dropdown#9408
Merged
Conversation
Contributor
maximemulder
left a comment
There was a problem hiding this comment.
I just discovered php/libraries/CenterID.php and I do not like it (I do like the new type pattern when it is well done though).
PR works, just look at the comment and address it (or not) ,and I'll approve the PR !
maximemulder
approved these changes
Oct 28, 2024
Collaborator
|
What is "a candidate's default site"? |
Collaborator
|
@driusan according to the code it seems to be registration project... I dont know why this one would be preferred. I would have went with default to last site used? but both are error prone IMO |
Collaborator
|
Coming back to this after I do an investigation to see if it is still needed as an override |
Collaborator
|
Discussion summary: The default site should be kept, but based on the last registered visit's site instead of the candidate's registration centerID |
driusan
reviewed
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
In the create timepoint module, adds a candidate's site as the site of the most recent visit to the 'Site' dropdown
Testing instructions (if applicable)
CCNA Override