[NDB_BVL_Instrument] Hide inactive examiners for site from selection, unless if already selected #9416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
reviewed
Oct 29, 2024
skarya22
commented
Oct 31, 2024
driusan
reviewed
Nov 11, 2024
driusan
pushed a commit
that referenced
this pull request
Mar 11, 2025
…nary (#9667) - raisinbread BMI instrument was not opening due to a change I made in #9416 where getExaminerFields in NDB_BVL_Instrument now relied on data being present in the instrument's dictionary. - Unfortunately, when loading a LINST instrument with Direct Entry enabled, it would first run _addMetadataFields, and then add metadata fields to the dictionary - _addMetadataFields would then call getExaminerFields causing it to fail, since getExaminerFields relies on the dictionary having metadata, but the metadata is added after _addMetadataFields - The change has been made so _addMetadataFields is run _after_ metadata is entered in the instance's dictionary. Further, metadata fields are only added to the instances dictionary if direct entry is not enabled. Otherwise they were added to the dictionary when they did not exist. * Resolves #9582, #9644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
CCNA OVERRIDE PR