[NDB_BVL_Instrument] Fix for clearing instrument#9411
Merged
Conversation
Collaborator
|
I am confused.. how does an instrument get non-nullable fields? What is the value before data entry is done? |
Contributor
Author
CommentID is a non-nullable field. When using the clear instrument function it results in an error as it tries to set the CommentID to null. |
Collaborator
|
Should the check be and FIELD_NAME != CommentID then? I'm afraid of what might happen if a different column has a non-null constraint and it just doesn't get cleared but the user thinks it does. At least if there's an error they would know there's something that went wrong to report. |
Contributor
Author
|
@driusan Yeah I can change it to that |
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
Ignore commentID when clearing instrument. When running clear instrument on a non JSON instrument the commentID primary key is non-nullable, which it tries to set values to null which results in an error, this is resolved. Ignore CommentID when clearing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
CCNA OVERRIDE PR