[dictionary] optimize unique scan types #9453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
previously approved these changes
Nov 7, 2024
Collaborator
|
Seems like a pretty simple bug fix.. should this be going to 26 or main? |
Contributor
Author
|
Ah 26 is the way to go, we need this on HBCD. My bad, rebase needed. |
Contributor
Author
|
Closing for 9454 |
driusan
pushed a commit
that referenced
this pull request
Nov 7, 2024
- optimize the list of scan types returned. - HBCD has a lot of scan types, only returning unique ones fixes `dictionary` module (it is not loading with the new QueryEngine). Rebase #9453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
dictionarymodule (it is not loading with the new QueryEngine).