Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[electrophysiology_uploader] Fix minor unexpected behaviours #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 2 commits into from
Nov 26, 2024
Merged

[electrophysiology_uploader] Fix minor unexpected behaviours #9470

driusan merged 2 commits into from
Nov 26, 2024

Conversation

@ZhichGaming
Copy link
Contributor

@ZhichGaming ZhichGaming commented Nov 15, 2024

Brief summary of changes

  • Update Browse tab on successful upload of a file.
  • Clear any possible error messages from previous file uploads when selecting a file.

Testing instructions (if applicable)

  1. Upload a file with a name that does not fit the convention and press submit
  2. Upload a valid file

Link(s) to related issue(s)

laemtl
laemtl previously approved these changes Nov 25, 2024
View reviewed changes
@laemtl
Copy link
Contributor

laemtl commented Nov 25, 2024 •
edited
Loading

Those issues were addressed in the HBCD upgrade. Approving this PR as the logic is good, and will revisit with the HBCD changes shortly. Ideally, it should be base on v26 to minimize the HBCD overrides.

@regisoc
Copy link
Contributor

regisoc commented Nov 25, 2024

@ZhichGaming thanks for this PR!
Since @laemtl already made the review, looks good. Can you rebase it to 26.0-release branch?
For some context, HBCD is one of the projects using LORIS, and it will use this change pretty soon.

@regisoc regisoc added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 25, 2024
@ZhichGaming ZhichGaming force-pushed the 2024_11_13_electrophysiology_uploader_ui_behavior branch from e0a5dd5 to 34fd496 Compare November 25, 2024 22:30
@ZhichGaming ZhichGaming force-pushed the 2024_11_13_electrophysiology_uploader_ui_behavior branch from 34fd496 to 74d5383 Compare November 25, 2024 22:34
@ZhichGaming ZhichGaming changed the base branch from main to 26.0-release November 25, 2024 22:35
@ZhichGaming ZhichGaming dismissed laemtl’s stale review November 25, 2024 22:35

The base branch was changed.

@ZhichGaming
Copy link
Contributor Author

ZhichGaming commented Nov 25, 2024

This is my first time rebasing, could you check if all is good?

@driusan
Copy link
Collaborator

driusan commented Nov 26, 2024

Thanks @ZhichGaming! Looks like it was rebased properly to me.

driusan
driusan approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laemtl's review was autodismissed because of the rebase, I didn't review but it looks like it's the same changes..

@driusan driusan merged commit 8f118bd into aces:26.0-release Nov 26, 2024
@ZhichGaming ZhichGaming deleted the 2024_11_13_electrophysiology_uploader_ui_behavior branch November 29, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan approved these changes

@laemtl laemtl laemtl left review comments

Assignees

@regisoc regisoc

Labels

State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[electrophysiology_uploader] Minor unexpected behaviours

4 participants

@ZhichGaming @laemtl @regisoc @driusan