Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[conflict_resolver] Resolved tab load speed #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
victori444 wants to merge 4 commits into from
Closed

[conflict_resolver] Resolved tab load speed #9488

victori444 wants to merge 4 commits into from

Conversation

@victori444
Copy link
Contributor

@victori444 victori444 commented Nov 27, 2024 •
edited
Loading

Brief summary of changes

Fixes load speed of the CR's resolved conflicts tab that was failing because of too much data.

  • Queries for the projectid and centerid while keeping their full names in the filter for Project & Site
  • Replaces fields "Value 1" and "Value 2" with "Incorrect Value" -> moved to this PR

Testing instructions (if applicable)

  1. Check that both resolved/unresolved tabs of the module load properly
  2. In the resolved tab, check that the Project & Site filters works

CCNA Override

@maximemulder maximemulder added Project: CCNA Issue or PR related to the CCNA project Category: Perfomance Issue or PR that aims to report or improve perfomance and removed Priority: Projects labels Nov 29, 2024
@ridz1208
Copy link
Collaborator

ridz1208 commented Dec 9, 2024

@CamilleBeau to look into if the override still applies to LORIS
@victori444 to split into 2 PRs

@victori444 victori444 mentioned this pull request Dec 10, 2024
Merged
driusan pushed a commit that referenced this pull request Jan 9, 2025
@victori444
[conflict_resolver] Replace 'Value 1 & 2' with 'Incorrect Answer' (#9506
b3ccf31 
)

In the Conflict Resolver's Resolved tab, replaces the fields 'Value 1'
and 'Value 2' with 'Incorrect Answer'
(changes brought over from #9488)
@CamilleBeau
Copy link
Collaborator

CamilleBeau commented Sep 18, 2025

I think we can close this and get rid of the override on CCNA

@CamilleBeau CamilleBeau assigned driusan and unassigned CamilleBeau Sep 18, 2025
@driusan
Copy link
Collaborator

driusan commented Sep 19, 2025

Okay

@driusan driusan closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@driusan driusan

Labels

Category: Perfomance Issue or PR that aims to report or improve perfomance Project: CCNA Issue or PR related to the CCNA project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@victori444 @ridz1208 @CamilleBeau @driusan @maximemulder