[media] Fix download of filenames with commas #9510
Conversation
|
I think I do not have a working media module on my vm as even outside of this PR I get this error when trying to upload and downloads don't work either |
racostas
left a comment
There was a problem hiding this comment.
Helping testing since @skarya22 have some issues with the VM.
This are my findings:
-
Not sure if we will have this case - in the practice - since the media module is not as free in the name we can choose for the files as the document repository. The file names have to follow a very specific format . I don't think we (or others) use commas in the visit name, the PCSIDs, or the instrument names.
-
After the changes the module continues to work fine. Media can be uploaded et downloaded.
-
Tested with a file that contains a comma in the name also worked.
Conclusions:
Looks good.
|
@victori444 , the PR looks good to my, still need to be rebased to solve de conflicts. Thanks you !! |
|
Thank you rolando! |
8333b49 to
92742ec
Compare
racostas
left a comment
There was a problem hiding this comment.
retested after rebase: all looks good to me.
Brief summary of changes
In the Media module, allows files with names containing commas to be downloaded (would previously result in an error)
Testing instructions (if applicable)
Link(s) to related issue(s)
The same fix was made here for the document repository