Merged
Conversation
7bea492 to
196a12a
Compare
skarya22
reviewed
Feb 18, 2025
Contributor
skarya22
left a comment
There was a problem hiding this comment.
Few comments after code review, testing now
| // phan only understands method_exists on simple variables, not | ||
| // Assigning to a variable is the a workaround | ||
| // for false positive 'getCenterIDs doesn't exist errors suggested | ||
| // in https://github.com/phan/phan/issues/2628 |
Contributor
There was a problem hiding this comment.
Just adding this for documentation, #7309 was involved in this too
Co-authored-by: Saagar Arya <[email protected]>
Co-authored-by: Saagar Arya <[email protected]>
skarya22
approved these changes
Feb 18, 2025
Contributor
skarya22
left a comment
There was a problem hiding this comment.
LGTM! Tested with a custom script and all the filters work well.
driusan
approved these changes
Feb 18, 2025
Collaborator
There was a problem hiding this comment.
Most of these doc comments could have just been "{@inheritdoc}", but the ones written are fine too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR creates new filters and modifies existing ones to add functionality and make them more scalable. Two new composite filters can also be used to join other filters in an AND or OR logic. These filters should allow us to move away from writing a new filter with "combined" functionality for each module (i.e.
UserProjectMatchOrHasAnyPermissions) instead you can use independent filters and join them in the order you need them to be.Changes in PR #9549 demo the use of these filters and how to combine them
PS these changes should not break existing code
Testing instructions (if applicable)
Link(s) to related issue(s)