Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[user_accounts] Made Site & Project multiselect expandable#9562

Merged
driusan merged 1 commit intoaces:26.0-releasefrom
ridz1208:expand_multiselect
Feb 18, 2025
Merged

[user_accounts] Made Site & Project multiselect expandable#9562
driusan merged 1 commit intoaces:26.0-releasefrom
ridz1208:expand_multiselect

Conversation

@ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Feb 13, 2025

Brief summary of changes

CBIG has a lot of sites and projects and the tiny 10px sized multiselects are just not cutting it anymore, they are extremely difficult to work with. This PR is 100% self isolated to the user_accounts module and only affects the site and project selects.

attached are 2 images to contrast the expandable selects vs the non expandable. NOTE that I made the changes to both sites and projects, the screeshots are simply to compare and contrast before vs after

Screenshot from 2025-02-13 00-01-07
Screenshot from 2025-02-13 00-01-24

Testing instructions (if applicable)

  1. make still work

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@ridz1208 ridz1208 added Category: Feature PR or issue that aims to introduce a new feature Area: UI PR or issue related to the user interface Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Language: PHP PR or issue that update PHP code Project: C-BIG & ARCHIMEDES Issue or PR related to the C-BIG project Difficulty: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) Area: Imaging PR or issue related to imaging Module: user_accounts PR or issue related to the user_accounts module labels Feb 13, 2025
@ridz1208 ridz1208 added this to the 26.0.2 milestone Feb 13, 2025
@driusan driusan modified the milestones: 26.0.2, 26.0.5 Feb 13, 2025
GeorgeMurad
GeorgeMurad approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 983c996 into aces:26.0-release Feb 18, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeMurad GeorgeMurad GeorgeMurad approved these changes

Assignees

@GeorgeMurad GeorgeMurad

Labels

Area: Imaging PR or issue related to imaging Area: UI PR or issue related to the user interface Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Category: Feature PR or issue that aims to introduce a new feature Difficulty: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) Language: PHP PR or issue that update PHP code Module: user_accounts PR or issue related to the user_accounts module Project: C-BIG & ARCHIMEDES Issue or PR related to the C-BIG project

Projects

None yet

Milestone

26.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@ridz1208 @GeorgeMurad @driusan