Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dashboard] Improve visual styling for a more modern look #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 15 commits into from
Apr 11, 2025
Merged

[dashboard] Improve visual styling for a more modern look #9734

driusan merged 15 commits into from
Apr 11, 2025

Conversation

@GeorgeMurad
Copy link
Contributor

@GeorgeMurad GeorgeMurad commented Mar 27, 2025 •
edited
Loading

Brief summary of changes

  • Change and modify the dashboard view by using new 3d style on the charts and adding new button Filters.

Testing instructions (if applicable)

  1. Check the Recruitment - site breakdown view as you will notice the new 3d view for the charts appears with no Filter.
  2. Click Filter it will take you directly to the "Recruitment - site breakdown".
  3. Click on any option in the filter and re-click on the Clear selection. It will clear the option you chose.
  4. By filtering, you will notice that the charts change dynamically without the submit button.

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Mar 27, 2025

@GeorgeMurad This is failing static tests

@GeorgeMurad
Copy link
Contributor Author

GeorgeMurad commented Mar 27, 2025

@GeorgeMurad This is failing static tests

I am on it.

skarya22
skarya22 reviewed Mar 31, 2025
View reviewed changes
@skarya22
Copy link
Contributor

skarya22 commented Mar 31, 2025

Can you also change width: targetModal ? 1000 : 350, to width: targetModal ? 1000 : 700, in chartBuilder.js for the styling of the createBarChart function?

@CamilleBeau CamilleBeau added Module: dashboard PR or issue related to dashboard module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 31, 2025
skarya22
skarya22 requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest seems great but I don't like the idea of moving setActiveView outside of the Panel element

@skarya22 skarya22 assigned GeorgeMurad and unassigned skarya22 Apr 7, 2025
@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Apr 7, 2025
@GeorgeMurad GeorgeMurad requested a review from skarya22 April 11, 2025 15:10
skarya22
skarya22 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 27! For 28, will create a new issue to make the settings such as sizing / positioning more modular. (ie making a chart take up two columns instead of one)

@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label Apr 11, 2025
@skarya22 skarya22 added this to the 27.0.0 milestone Apr 11, 2025
@ridz1208
Copy link
Collaborator

ridz1208 commented Apr 11, 2025

@GeorgeMurad @skarya22 Can one of you possibly put some screenshots on this PR? I was hoping to share this with a couple collaborators get their opinion.

@skarya22
Copy link
Contributor

skarya22 commented Apr 11, 2025 •
edited
Loading

@ridz1208 it's functionally the same as before
image
image
image

@GeorgeMurad
Copy link
Contributor Author

GeorgeMurad commented Apr 11, 2025

Dashboard_4

@ridz1208
Copy link
Collaborator

ridz1208 commented Apr 11, 2025

Thank you!

@driusan driusan merged commit 35d44a6 into aces:main Apr 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skarya22 skarya22 skarya22 approved these changes

Assignees

@GeorgeMurad GeorgeMurad

Labels

27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: dashboard PR or issue related to dashboard module

Projects

None yet

Milestone

27.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GeorgeMurad @driusan @skarya22 @ridz1208 @CamilleBeau