[candidate_parameters] Fix DB select with iterator_to_array #9733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@CamilleBeau did you try this with a candidate that returns 0 rows to ensure it's encoded as |
Collaborator
Author
Yes I tried with both a participant with and without data |
jeffersoncasimir
approved these changes
Apr 9, 2025
Contributor
jeffersoncasimir
left a comment
There was a problem hiding this comment.
The error is no longer triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR wraps the $db->pselect() call with iterator_to_array so that it can be processed with .map in DiagnosisEvolution.js. This is necessary following the change in #9334
Testing instructions (if applicable)
Link(s) to related issue(s)