Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@skarya22
Copy link
Contributor

@skarya22 skarya22 commented Apr 7, 2025

Brief summary of changes

  • Updated the New Test form in the Battery Manager to better showcase that selecting a DDE option is required.
  • It defaults to No, and includes a red * that the field is required.
image

Testing instructions (if applicable)

  1. Try to create a new Test without modifying the DDE selection and confirm it works
  2. Try to create a new Test with DDE == 'Yes' and confirm it works

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Apr 11, 2025

@GeorgeMurad can you review/test?

@driusan driusan requested a review from GeorgeMurad April 11, 2025 19:02
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It works for both Yes and No options.

@driusan driusan merged commit a9df2b1 into aces:main Apr 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Battery Manager] 'Enable Double Data Entry' has no warning or indication that it is a required entry when submitting a 'New Test'

3 participants