Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DataTable] Fix multiselect containing commas #9743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 2 commits into from
Jun 6, 2025
Merged

[DataTable] Fix multiselect containing commas #9743

driusan merged 2 commits into from
Jun 6, 2025

Conversation

@victori444
Copy link
Contributor

@victori444 victori444 commented Apr 10, 2025

Brief summary of changes

When selected, multiselect filter options containing a comma would not display any data because they were being split by commas (see below).

Screenshot 2025-04-10 at 12 41 33 PM 430114218-5992aec4-172f-4d70-8c5e-4c38155e4c96

Testing instructions (if applicable)

  1. In a multiselect filter that contains options with commas (eg. in CCNA, the Site filter in Access Profile) and see that the corresponding data appear in the table
  2. Check that multiple options can be selected & displayed appropriately, including options that contain a comma

Link(s) to related issue(s)

@skarya22
Copy link
Contributor

skarya22 commented Apr 14, 2025

This is failing all GitHub actions since it is on an older LORIS branch, not because it is necessarily breaking @driusan

@kongtiaowang
Copy link
Contributor

kongtiaowang commented Apr 15, 2025

After Fix Github CI testing - 24.1 #9753 merged, rebase this PR will fix the errors.

@driusan
Copy link
Collaborator

driusan commented Apr 16, 2025

#9753 is merged

@skarya22 skarya22 assigned victori444 and unassigned kongtiaowang Apr 17, 2025
@skarya22 skarya22 added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Apr 17, 2025
@victori444 victori444 force-pushed the 2025_04_10_v24_bugfix_access_profile_filter branch from 39d907f to 2b24227 Compare April 24, 2025 17:28
@victori444 victori444 force-pushed the 2025_04_10_v24_bugfix_access_profile_filter branch from 2b24227 to 5c9cfa5 Compare April 24, 2025 17:47
@skarya22 skarya22 removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Apr 25, 2025
@CamilleBeau CamilleBeau requested a review from kongtiaowang June 4, 2025 17:04
kongtiaowang
kongtiaowang approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 5e7884d into aces:24.1-release Jun 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees

@kongtiaowang kongtiaowang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victori444 @skarya22 @kongtiaowang @driusan