Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[Core] Fix redirect URL AGAIN#9794

Merged
driusan merged 1 commit intoaces:26.0-releasefrom
ridz1208:fix_redirect_again
Aug 25, 2025
Merged

[Core] Fix redirect URL AGAIN#9794
driusan merged 1 commit intoaces:26.0-releasefrom
ridz1208:fix_redirect_again

Conversation

@ridz1208
Copy link
Collaborator

Brief summary of changes

Fixes even further what was fixed in #9534. It seems like the fix in the previous PR did not account for arguments coming after the ? in the URL, this new parameter should account for it.

Here is a list of Query params and what they look like in case nother might still be better

    [HTTP_HOST] => localhost:8083
    [REDIRECT_URL] => /candidate_parameters/
    [REDIRECT_QUERY_STRING] => lorispath=candidate_parameters/&candID=446836&identifier=446836
    [QUERY_STRING] => lorispath=candidate_parameters/&candID=446836&identifier=446836
    [REQUEST_URI] => /candidate_parameters/?candID=446836&identifier=446836

Testing instructions (if applicable)

  1. Do the following for several different URLs
  2. log in as a user and navigate to a page
  3. copy the URL form that page and open an incognito window
  4. paste the URL, you should get a 403 error with an option to "try logging in"
  5. click on that option and enter your credentials
  6. make sure you get to the same page as step 2
  7. try same steps for other pages with a diversity of URL formats

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@ridz1208 ridz1208 added Area: UI PR or issue related to the user interface Language: PHP PR or issue that update PHP code 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Difficulty: Simple PR or issue that should be easy to implement, review, or test labels May 15, 2025
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 00c8f82 into aces:26.0-release Aug 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Area: UI PR or issue related to the user interface Difficulty: Simple PR or issue that should be easy to implement, review, or test Language: PHP PR or issue that update PHP code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants