Extract permission actions #9872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@regisoc There are some conflicts to resolve here |
Contributor
Author
|
Yes, and there is this new permission |
Contributor
Author
|
@CamilleBeau done, ready to review. |
CamilleBeau
approved these changes
Jul 10, 2025
Collaborator
CamilleBeau
left a comment
There was a problem hiding this comment.
Looks good & passing manual test! I tested sourcing the raisinbread data as well as with the new patch / script.
jeffersoncasimir
pushed a commit
to jeffersoncasimir/Loris
that referenced
this pull request
Aug 11, 2025
Extracts each individual permission action into a new table, i.e. instead of having `Create/Delete` as a permission action, the `permissions_action` will list all possible actions, and the link with permission will be done in the rel table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR extracts each individual permission action into a new table, i.e. instead of having
Create/Deleteas a permission action, thepermissions_actionwill list all possible actions, and the link with permission will be done in the rel table.current errors are related to RB updateIssue:
need an update for this new permissionincludedview_instrument_datapushed in 27.0: [instruments] Add view permission #9762To apply this change: