Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[dataquery]Fix shared query name not displaying #9887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 1 commit into from
Oct 30, 2025
Merged

[dataquery]Fix shared query name not displaying #9887

driusan merged 1 commit into from
Oct 30, 2025

Conversation

@shonibare
Copy link
Contributor

@shonibare shonibare commented Jun 24, 2025

Fixes #9856

Testing:

  1. Name and share a query from the recent queries
  2. Log in with another user account to see the query shared/named in the Share queries.

@shonibare shonibare added Module: dataquery PR or issue related to (new) dataquery module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Jun 24, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Jun 24, 2025
@skarya22
Copy link
Contributor

skarya22 commented Jul 8, 2025

I'm a bit confused, I have the following query shared from admin:
image
But when I login as my user with dictionary+dataquery permission, as well as every project and site, I have no shared queries:
image
@driusan @adamdaudrich Is this the expected behaviour? Am I missing anything? Tagging you since Moshood is on vacation

@driusan
Copy link
Collaborator

driusan commented Jul 8, 2025

@skarya22 No, that is confusing. You need to have access to all fields used in a query to have access to the query, so my first thought is maybe you don't have access to the candidate_parameters module that provides the field?

skarya22
skarya22 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skarya22 skarya22 added the Passed manual tests PR has been successfully tested by at least one peer label Jul 8, 2025
@driusan driusan merged commit c384e6a into aces:27.0-release Oct 30, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skarya22 skarya22 skarya22 approved these changes

Assignees

@skarya22 skarya22

Labels

27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: PHP PR or issue that update PHP code Module: dataquery PR or issue related to (new) dataquery module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shonibare @skarya22 @driusan