[datadict] Fix missing variables & ignore meta fields#9955
Merged
driusan merged 2 commits intoaces:26.0-releasefrom Nov 21, 2025
Merged
[datadict] Fix missing variables & ignore meta fields#9955driusan merged 2 commits intoaces:26.0-releasefrom
driusan merged 2 commits intoaces:26.0-releasefrom
Conversation
ridz1208
commented
Aug 11, 2025
| break; | ||
|
|
||
| //for HTML_QuickForm versions of standard HTML Form Elements... | ||
| case "jsondata": |
Collaborator
Author
There was a problem hiding this comment.
@jeffersoncasimir did we have other headers toignore here?
nicolasbrossard
approved these changes
Sep 23, 2025
Collaborator
|
@ridz1208 Failing tests |
Contributor
|
Tested on my VM:
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Just some fixes that were necessary on CBIG to be able to build the dictionary
TODO if I get time make the script check if the instrument is an instance of the Instrument class rather than pattern matching on 'extends NDB_BVL_Instrument'
Testing instructions (if applicable)
Link(s) to related issue(s)