[LINST] Fix loading of LINST instruments #10079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINST instruments currently throw an exception because getExaminerNames is
called to get a list of examiners to pass to addElement. However, getExaminerNames
calls getField("Examiner") to get the default value. Since addElement hasn't
been called yet, it throws an exception saying the field does not exist
for the instrument.
This bypasses it by calling getInstanceData and getting the examiner key
directly.
8bebd60 to
15424f7
Compare
racostas
approved these changes
Oct 31, 2025
Contributor
racostas
left a comment
There was a problem hiding this comment.
LGTM.
Now BMI (LINST instrument in RB) is loading properly
Before I this PR I got the following 500 error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINST instruments currently throw an exception because getExaminerNames is called to get a list of examiners to pass to addElement. However, getExaminerNames calls getField("Examiner") to get the default value. Since addElement hasn't been called yet, it throws an exception saying the field does not exist for the instrument.
This bypasses it by calling getInstanceData and getting the examiner key directly.