Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Core] Remove polyfiller / resurrect Loris #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 7 commits into from
Sep 14, 2016
Merged

[Core] Remove polyfiller / resurrect Loris #2179

driusan merged 7 commits into from
Sep 14, 2016

Conversation

@alisterdev
Copy link
Contributor

@alisterdev alisterdev commented Sep 13, 2016 •
edited
Loading

  • Remove call to polyfiller in main.tpl
  • Update modernizr to lates version
  • Use modernizr to detect <input type="date"> and replace it with jquery datepicker
  • Add custom js/css for datepicker

Note 1: Currently jquery-ui is required for dialogs and datepickers to work. In the future release, dialogs should be replaced with bootstrap dialogs and datepickers only created by modernizr.

PS: Here's how the date picker will look in Firefox and when explicitly invoked in Chrome (i.e candidate_list)

image

@alisterdev alisterdev added the Category: Bug PR or issue that aims to report or fix a bug label Sep 13, 2016
@alisterdev alisterdev added this to the 16.1 milestone Sep 13, 2016
@driusan driusan added the State: Needs work PR awaiting additional work by the author to proceed label Sep 13, 2016
@driusan
Copy link
Collaborator

driusan commented Sep 13, 2016

@alisterdev This is failing Travis

@codecov-io
Copy link

codecov-io commented Sep 13, 2016

Current coverage is 13.71% (diff: 11.76%)

Merging #2179 into 16.1-dev will decrease coverage by 0.99%

@@           16.1-dev      #2179   diff @@
==========================================
  Files           118        118           
  Lines         21412      20067   -1345   
  Methods        1285       1116    -169   
  Messages          0          0           
  Branches          0          0           
==========================================
- Hits           3150       2752    -398   
+ Misses        18262      17315    -947   
  Partials          0          0

Sunburst

Powered by Codecov. Last update 5ca12c1...bbd409b

@alisterdev
Copy link
Contributor Author

alisterdev commented Sep 13, 2016

@driusan Ready to merge

@alisterdev alisterdev removed the State: Needs work PR awaiting additional work by the author to proceed label Sep 13, 2016
@driusan driusan modified the milestones: 16.1.1, 16.1 Sep 14, 2016
@ridz1208 ridz1208 self-assigned this Sep 14, 2016
@ridz1208 ridz1208 added the Passed manual tests PR has been successfully tested by at least one peer label Sep 14, 2016
@ridz1208
Copy link
Collaborator

ridz1208 commented Sep 14, 2016

@driusan tested a few modules and a few instruments on chrome 53, all works fine

@driusan driusan merged commit 33e0422 into aces:16.1-dev Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@driusan driusan

@alisterdev alisterdev

@ridz1208 ridz1208

Labels

Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

16.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@alisterdev @driusan @codecov-io @ridz1208