Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Conflict Resolver] Display Examiner's full_name rather than examinerID #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 2 commits into from
Jun 21, 2017
Merged

[Conflict Resolver] Display Examiner's full_name rather than examinerID #2891

driusan merged 2 commits into from
Jun 21, 2017

Conversation

@davidblader
Copy link
Contributor

@davidblader davidblader commented Jun 16, 2017

Conflict Resolver displays the examinerID for conflicts in the Examiner field making it difficult / impossible for anyone doing conflict resolution to resolve this field

To test:

  1. create a data entry conflict for the Examiner field if your DB does not have any already
  2. resolve Examiner conflict & make sure examiner names populate the select
  3. check respective instrument table that ExaminerID is valid for the resolved conflict
  4. comment "Good job, David! 🍻" and approve PR

@davidblader davidblader added the Category: Bug PR or issue that aims to report or fix a bug label Jun 16, 2017
@davidblader davidblader added this to the 17.0 milestone Jun 16, 2017
@ridz1208 ridz1208 added the Passed manual tests PR has been successfully tested by at least one peer label Jun 20, 2017
@driusan driusan merged commit c0bdd48 into aces:17.0-dev Jun 21, 2017
kongtiaowang added a commit to kongtiaowang/Loris that referenced this pull request Jul 26, 2017
@kongtiaowang
retrieve to aces#2891
a0931fe
@kongtiaowang kongtiaowang mentioned this pull request Jul 26, 2017
Closed
@skarya22 skarya22 mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridz1208 ridz1208 ridz1208 approved these changes

Assignees

@mohadesz mohadesz

@ridz1208 ridz1208

Labels

Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidblader @ridz1208 @driusan @mohadesz