Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[16.0][IMP] web_form_view_resizable: proporitonal min/maxWidth, resize with pdfpreview, jumping issue when resizing #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[16.0][IMP] web_form_view_resizable: proporitonal min/maxWidth, resize with pdfpreview, jumping issue when resizing #18

merged 1 commit into from
Mar 17, 2025

Conversation

@AnizR
Copy link

@AnizR AnizR commented Mar 17, 2025

Some improvements over PR OCA#2976:

  • Set min/maxWidth proportional to the size of the window
  • When dragging to expand the form view over a pdf preview, it was a bit 'buggy': when hovering the div containing the preview while dragging, the scaling was stopping.
  • When clicking on the handle to resize the form, there was a weird behaviour:
    "...I grab the resize handle it shoots to the right a couple of pixels first(like 100px or so)..." ([16.0][ADD] web_form_view_resizable OCA/web#2976 (review))

@AnizR AnizR requested a review from sbejaoui March 17, 2025 15:38
@sbejaoui sbejaoui merged commit 972f79d into 16.0-web_form_view_resizable-sbj Mar 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbejaoui sbejaoui Awaiting requested review from sbejaoui

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnizR @sbejaoui @acsone-git-bot