[FIX] Allow to execute a valid sys.path entry. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 86.34% 86.48% +0.14%
==========================================
Files 7 7
Lines 205 222 +17
Branches 31 31
==========================================
+ Hits 177 192 +15
- Misses 20 22 +2
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea50a10 to
87ba722
Compare
click-odoo is using runpy.run_path(path_name, ...) function. path_name can be a file, but can be also a folder, in the case we want to import a syst.path entry, containing a __main__.py file. this patch allow such call.
87ba722 to
67fbfbd
Compare
sbidoul
reviewed
Oct 13, 2025
Co-authored-by: Stéphane Bidoul <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. First, thanks for this great tool I began to use some weeks ago.
About that fix:
click-odoo is using
runpy.run_path(path_name, ...)function.path_namecan be a file, but can be also a folder, in the case we want to import a syst.path entry, containing a__main__.pyfile.this patch allow such call.
Ref : https://docs.python.org/3/library/runpy.html#runpy.run_path
Hi. this is a quite trivial patch. This is the first time I contribute on click-odoo, let me know if extra things are required.