Early experimental stage of menu and workspace bar #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very early stage of workspace app icon gui bar and menu settings, currently tied to config file so any changes in menu get written to a config file for persistance
Owner
|
so my only concern with this is that this is almost like adding a sketchybar implementation into rift and i am not totally sure that this should be packaged in. i would be interested in maybe adding it as a first class plugin of some kind(maybe we could expose a crate that interfaces with the mach api and it would not even require too complex of a code change) since this feels a little out of scope. i feel like it makes sense to defer to yabai's approach to this as they once had a menubar thing like this in the source and then extracted it which led to the creation of sketchybar.. although, i am not totally sure and i think there needs to be some more discourse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early stage of workspace app icon gui bar and menu settings, currently tied to config file so any changes in menu get written to a config file for persistance. Not sure if you like it @acsandmann and any suggestiosn would greatly be appreciated.