fix: ensure at least once delivery on broker IssueAsync #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
reviewed
May 24, 2022
Co-authored-by: Rob Ede <[email protected]>
robjtede
approved these changes
May 24, 2022
fredynaruton
approved these changes
Jul 4, 2023
robjtede
pushed a commit
to Michael-F-Bryan/actix
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix
PR Checklist
Check your PR fulfills the following:
Overview
While the broker API is really not great, it did offer the guarantee of at-least-once delivery previously on
issue_async.Since the
do_senddoesn't return a result anymore, it was changed to atry_sendwhich dropped the message on mailbox full.This PR catches this error and will enqueue the message using
do_send. I kept the firsttry_sendto detect closed mailbox and detach them from the broker (which was the previous behaviour).Ideally the broker would follow the same API as the actor and have something like a
do_send,try_sendandsendinstead. But this is a larger change that is out of scope for the current fix.Closes #534