-
Notifications
You must be signed in to change notification settings - Fork 0
Init #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Endpoint configuration Co-authored-by: anikaweinmann <[email protected]> Co-authored-by: Carmen Tawalika <[email protected]> Co-authored-by: Marc Jansen <[email protected]>
* linting tests + black workflow * linting * black * further black * fix unittests * fix test Co-authored-by: anikaweinmann <[email protected]>
* linting tests + black workflow * linting * black * further black * fix unittests * fix test Co-authored-by: anikaweinmann <[email protected]>
* add job queue name to response * lint * Update src/actinia_core/models/response_models.py Co-authored-by: Markus Neteler <[email protected]> * black * undo-black Co-authored-by: Markus Neteler <[email protected]>
* job resumption working without new process chain * linting and job resumption readme * improve example * fix job resumption * Apply suggestions from code review Co-authored-by: Carmen Tawalika <[email protected]> Co-authored-by: anikaweinmann <[email protected]> Co-authored-by: Carmen Tawalika <[email protected]>
* allow one job queue per user * update config comments * simplify * lint * update readme
* make resource resource delition asynchron * trailing and ending precommit ... * do not use pylint * trigger linting * linting * linting --------- Co-authored-by: anikaweinmann <[email protected]>
* reactivate redis queue * rename variable * make queue type configurable * enhance dev setup for redis queue * lint * move user_auth * move user auth * move base_login * move map_layer_base * move renderer_base * move resource_base * fix relative imports * lint
* make resource resource delition asynchron * trailing and ending precommit ... * do not use pylint * trigger linting * linting * linting --------- Co-authored-by: anikaweinmann <[email protected]>
* add decorator for deprecated locations * add project endpoints * endpoints for projects * rename location * rename location * unify maintainer * fix GRASS Initialisation * black * fixes for tests and G83 * fixes * add rest of changes * Update tests/test_job_resumption.py * fix endpoints and job resumption tests * Update src/actinia_core/core/common/api_logger.py * Tests for G84 * Test pipelines for G8.3 and G8.4 * Update src/actinia_core/rest/base/resource_base.py * fix test workflow * fix tests for G83 * fix error due to lib update * fix proc name * Update src/actinia_core/endpoints.py Co-authored-by: Carmen Tawalika <[email protected]> --------- Co-authored-by: Carmen Tawalika <[email protected]> Co-authored-by: Carmen <[email protected]>
* update setup from redis to valkey * replace redis with valkey calls + remove non needed redis-remainings * replace redis import with valkey import * adjust function from redis to valkey * replace redis by valkey function * fix call of valkey commands fitting valkey-syntax * Semantic renaming: redis to kvdb (#602) * semantic renaming: redis to kvdb * remove non semantic changes * remove non semantic changes * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * remove non semantic changes * update readme * Update src/actinia_core/README.md Co-authored-by: Carmen Tawalika <[email protected]> * Update src/actinia_core/core/common/config.py Co-authored-by: Carmen Tawalika <[email protected]> * Update src/actinia_core/README.md Co-authored-by: Carmen Tawalika <[email protected]> * Update docker/actinia-core-alpine/actinia.cfg Co-authored-by: Carmen Tawalika <[email protected]> * PR review CT --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Carmen Tawalika <[email protected]> * linting: black --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Carmen Tawalika <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ruff
[ruff] reported by reviewdog 🐶
actinia-rest-lib/src/actinia_core/rest/base/resource_base.py
Lines 253 to 254 in d52d491
| def check_for_json(self): | |
| """Check if the Payload is a JSON document |
[ruff] reported by reviewdog 🐶
| message="No JSON data in request: Exception: %s" % str(e) |
[ruff] reported by reviewdog 🐶
actinia-rest-lib/src/actinia_core/rest/base/resource_base.py
Lines 277 to 278 in d52d491
| def check_for_xml(self): | |
| """Check if the Payload is a XML document |
[ruff] reported by reviewdog 🐶
[ruff] reported by reviewdog 🐶
| message="No XML data section in HTTP header." |
[ruff] reported by reviewdog 🐶
actinia-rest-lib/src/actinia_core/rest/base/resource_base.py
Lines 302 to 306 in d52d491
| else: | |
| self.create_error_response( | |
| message="Empty XML data section in HTTP header." | |
| ) | |
| return False |
[ruff] reported by reviewdog 🐶
| """Preprocessing steps for asynchronous processing |
[ruff] reported by reviewdog 🐶
actinia-rest-lib/src/actinia_core/rest/base/resource_base.py
Lines 348 to 350 in d52d491
| else: | |
| if self.check_for_xml() is False: | |
| return None |
[ruff] reported by reviewdog 🐶
| "http://", "https://" |
[ruff] reported by reviewdog 🐶
| self.user_id, self.resource_id, self.iteration, self.response_data |
[ruff] reported by reviewdog 🐶
| """Return a unique request and resource id based on uuid4 |
[ruff] reported by reviewdog 🐶
| """ |
[ruff] reported by reviewdog 🐶
| """Wait until a resource finished, terminated or failed with an error |
[ruff] reported by reviewdog 🐶
| """ |
[ruff] reported by reviewdog 🐶
| self.user_id, self.resource_id, self.iteration |
* add decorator for deprecated locations * add project endpoints * endpoints for projects * rename location * rename location * unify maintainer * fix GRASS Initialisation * black * fixes for tests and G83 * fixes * add rest of changes * Update tests/test_job_resumption.py * fix endpoints and job resumption tests * Update src/actinia_core/core/common/api_logger.py * Tests for G84 * Test pipelines for G8.3 and G8.4 * Update src/actinia_core/rest/base/resource_base.py * fix test workflow * fix tests for G83 * fix error due to lib update * fix proc name * Update src/actinia_core/endpoints.py Co-authored-by: Carmen Tawalika <[email protected]> --------- Co-authored-by: Carmen Tawalika <[email protected]> Co-authored-by: Carmen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think the README.md needs still be updated, rest looks good to me
This PR moves some modules and methods from actinia-core to this new library. These modules and methods are not only used by actinia-core but also by different plugins.
See actinia-org/actinia-core#627 for more details.